chore(deps): update dependency node-fetch to v2.6.1 #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
![renovate-approve[bot]](https://avatars.githubusercontent.com/in/7394?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
7 times, most recently
from
1298e3e
to
3ca9f3a
Compare
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
6 times, most recently
from
c99bfbf
to
869c79c
Compare
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
5 times, most recently
from
7bb6822
to
a43415e
Compare
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
4 times, most recently
from
641ba4d
to
d9e62f0
Compare
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
3 times, most recently
from
ecaa68f
to
fea1de9
Compare
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
3 times, most recently
from
715a52e
to
faeece3
Compare
|
This seems like a real conflict between a minor version update of |
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
2 times, most recently
from
2428820
to
b641924
Compare
renovate
bot
force-pushed
the
renovate/node-fetch-2.x
branch
from
b641924
to
de8304c
Compare
As of `node-fetch@2.4.0`, its internal representation of `body` is now normalized to a `Buffer` during `Request` construction, and will always be returned as a `Buffer`, rather than having the `body` being either a String _or_ a Buffer. This defeated the way we were testing the `body` but shouldn't affect the actual `Response`'s `body`. Ref: node-fetch/node-fetch@7d3293200a91a
abernix
force-pushed
the
renovate/node-fetch-2.x
branch
from
dafdb8b
to
df27762
Compare
glasser
approved these changes
Apr 30, 2021
abernix
added a commit
that referenced
this pull request
Apr 30, 2021
* chore(deps): update dependency node-fetch to v2.6.1 * tests: Use `toString()` method to test Buffer contents As of `node-fetch@2.4.0`, its internal representation of `body` is now normalized to a `Buffer` during `Request` construction, and will always be returned as a `Buffer`, rather than having the `body` being either a String _or_ a Buffer. This defeated the way we were testing the `body` but shouldn't affect the actual `Response`'s `body`. Ref: node-fetch/node-fetch@7d3293200a91a Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jesse Rosenberger <git@jro.cc>
glasser
added a commit
that referenced
this pull request
Apr 30, 2021
glasser
added a commit
that referenced
this pull request
Apr 30, 2021
|
This is released in AS 2.24.0! We don't think that Apollo Server was actually affected by the CVE patched in 2.6.1 but are happy to get this out anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.3.0->2.6.12.5.8->2.5.10Release Notes
bitinn/node-fetch
v2.6.1Compare Source
This is an important security release. It is strongly recommended to update as soon as possible.
See CHANGELOG for details.
v2.6.0Compare Source
See CHANGELOG.
v2.5.0Compare Source
See CHANGELOG.
v2.4.1Compare Source
See CHANGELOG.
v2.4.0Compare Source
See CHANGELOG.
Configuration
📅 Schedule: "every weekend" in timezone America/Los_Angeles.
🚦 Automerge: Enabled.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by WhiteSource Renovate. View repository job log here.