npmignore: Don't include the source of tests #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
force-pushed
the
glasser/no-bundle-tests
branch
2 times, most recently
from
71ce883 to
669c710
Compare
We know of no reason that including the source of tests in built npm packages would be helpful, and we've heard reports that including the RSA private key fixture as we do in apollo-server-core can trigger security scans. Change how we drop tests from "dist" to drop the whole test directory in case some other files sneak in there. Add a comment to the one npmignore file that differs from the others. Fixes #5781.
glasser
force-pushed
the
glasser/no-bundle-tests
branch
from
669c710 to
fd3462c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know of no reason that including the source of tests in built npm
packages would be helpful, and we've heard reports that including the
RSA private key fixture as we do in apollo-server-core can trigger
security scans.
Change how we drop tests from "dist" to drop the whole test directory in
case some other files sneak in there.
Fixes #5781.