apollo-server-core: Inline defaultUsageReportingSignature (for graphql@16) #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l@16) In v3.5 we made AS compatible with the changes in graphql@16, but apollo-server-core had a dependency on the somewhat inactive apollo-graphql package which doesn't yet allow graphql@16 in its peer deps. We should eventually publish a new version of apollo-graphql (eg, apollo-server-plugin-operation-registry also depends on it) but the Apollo Server usage reporting plugin is the only consumer of defaultUsageReportingSignature (and it is not important that the individual transforms that make it up stay compatible with the building blocks of other functions like the operation registry signature function) so inlining seems most natural. Fixes #5941.
glasser
force-pushed
the
glasser/apollo-graphql-inline
branch
from
ca6646c
to
68b5379
Compare
|
I tweaked comments a bit but otherwise the code is identical to the code in apollo-graphql. (Well, I did change the typing on the |
glasser
added a commit
that referenced
this pull request
Dec 21, 2021
In #5955 we inlined defaultUsageReportingSignature into apollo-server-core from apollo-graphql but left its tests behind. This brings the tests over too. The tests themselves including snapshots are verbatim from apollo-graphql.
glasser
added a commit
that referenced
this pull request
Dec 21, 2021
In #5955 we inlined defaultUsageReportingSignature into apollo-server-core from apollo-graphql but left its tests behind. This brings the tests over too. The tests themselves including snapshots are verbatim from apollo-graphql.
|
Whoops, this PR failed to actually change the import to the inlined code! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v3.5 we made AS compatible with the changes in graphql@16, but
apollo-server-core had a dependency on the somewhat inactive
apollo-graphql package which doesn't yet allow graphql@16 in its peer deps.
We should eventually publish a new version of apollo-graphql (eg,
apollo-server-plugin-operation-registry also depends on it) but the
Apollo Server usage reporting plugin is the only consumer of
defaultUsageReportingSignature (and it is not important that the
individual transforms that make it up stay compatible with the building
blocks of other functions like the operation registry signature
function) so inlining seems most natural.
Fixes #5941.