Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully replace 'ApolloError' with 'GraphQLError' #6355

Merged
merged 17 commits into from
Jun 2, 2022
Merged

Fully replace 'ApolloError' with 'GraphQLError' #6355

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
90a9bbf
Make `ApolloError` a subclass of `GraphQLError`
IvanGoncharov Apr 25, 2022
9a0eac4
Obscure error to simply be ApolloError
IvanGoncharov Apr 25, 2022
5415403
Fully replace 'ApolloError' with 'GraphQLError'
IvanGoncharov Apr 25, 2022
905b4a2
GraphQLError now has 'toJSON' that provide all those fields
IvanGoncharov May 2, 2022
8a27f39
Remove toApolloError
IvanGoncharov May 2, 2022
8966618
Fix type of return value for `formatApolloErrors`
IvanGoncharov May 9, 2022
ad03f0a
Update graphql to 16.5.0
IvanGoncharov May 9, 2022
afda3fe
Rename formatApolloErrors options to match rest of source code
IvanGoncharov May 23, 2022
a581ec0
Rewrite formatApolloErrors
IvanGoncharov May 24, 2022
5ec6eb6
Fix tests
IvanGoncharov May 30, 2022
79640b8
Fix prettier
IvanGoncharov Jun 2, 2022
77b7592
remove fromGraphQLError + change signature for Error constructor
IvanGoncharov Jun 2, 2022
fcedd6a
Add missing 'code' to "obscure error"
IvanGoncharov Jun 2, 2022
17140ac
Make handling of errors thrown by formatError more explicit
IvanGoncharov Jun 2, 2022
972b05b
added test to ensure we providing error code even for "obscure error"
IvanGoncharov Jun 2, 2022
e2c684d
Bring back integration test that tested how we handle error extensions
IvanGoncharov Jun 2, 2022
250e9f2
Address review comment
IvanGoncharov Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions packages/server/src/__tests__/integration/apolloServerTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,6 +1774,40 @@ export function defineIntegrationTestSuiteApolloServerTests(
expect(result.errors[0].extensions.exception).toBeDefined();
expect(result.errors[0].extensions.exception.stacktrace).toBeDefined();
});

it('shows error extensions in extensions (only!)', async () => {
const uri = await createServerAndGetUrl({
typeDefs: gql`
type Query {
fieldWhichWillError: String
}
`,
resolvers: {
Query: {
fieldWhichWillError: () => {
throw new AuthenticationError('Some message', {
extensions: { ext1: 'myExt' },
});
},
},
},
stopOnTerminationSignals: false,
nodeEnv: 'development',
});

const apolloFetch = createApolloFetch({ uri });

const result = await apolloFetch({ query: `{fieldWhichWillError}` });
expect(result.data).toEqual({ fieldWhichWillError: null });

expect(result.errors).toBeDefined();
expect(result.errors.length).toEqual(1);
expect(result.errors[0].message).toEqual('Some message');
expect(result.errors[0].extensions.code).toEqual('UNAUTHENTICATED');
expect(result.errors[0].extensions.ext1).toEqual('myExt');
expect(result.errors[0].extensions.exception).toBeDefined();
expect(result.errors[0].extensions.exception.ext1).toBeUndefined();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also check result.errors[0].extensions.exception.extensions is undefined? basically we want to make sure it isn't there twice. (Or we could just do an inline snapshot on result tbh)

});
});

describe('Persisted Queries', () => {
Expand Down