Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit AS4 exported API #6676

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Audit AS4 exported API #6676

merged 3 commits into from
Jul 13, 2022

Conversation

glasser
Copy link
Member

@glasser glasser commented Jul 13, 2022 •
edited
Loading

Fixes #6528. See individual commits.

@glasser
plugins: plugin-returning functions should return ApolloServerPlugin
0272fc5 
The InternalApolloServerPlugin and ImplicitlyInstallablePlugin types
shouldn't be part of our externally visible interface. (The only code
that cares about them uses guard functions to cast to them.)

Also export the default landing page options types.
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8019e90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 13, 2022 •
edited
Loading

❌ Deploy Preview for apollo-server-docs failed.

Name Link
🔨 Latest commit 8019e90
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/62cf2ea9a4692b00099e203d

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 13, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8019e90:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@glasser glasser changed the title plugins: plugin-returning functions should return ApolloServerPlugin Audit AS4 exported API Jul 13, 2022
@glasser glasser merged commit 5ab7aa2 into version-4 Jul 13, 2022
@glasser glasser deleted the glasser/v4-plugin-types branch July 13, 2022 21:03
@glasser
Copy link
Member Author

glasser commented Jul 13, 2022

Before we close #6528 we have two more questions:

Remove error exports altogether?
Difference between graphqlRequestContext.errors and graphqlRequestContext.response.result.errors?

@glasser glasser mentioned this pull request Jul 13, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trevor-scheer trevor-scheer trevor-scheer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glasser @trevor-scheer