Ensure executionDidEnd
hooks are only called once
#6846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction in first commit, resolution with test updates in second commit.
executionDidEnd
hooks are currently called within both the try and catch clauses of the same block. This means that if a hook throws, they'll be called again in the catch.Similar to changes made for
parsingDidEnd
in #6679, we now call theexecutionDidEnd
hooks after the try/catch and within the catch. This ensures they'll only ever be called once.Fixes #6567