Always send large traces as stats #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-server-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6bae36:
|
glasser
reviewed
Sep 20, 2022
packages/server/src/__tests__/plugin/usageReporting/stats.test.ts
Outdated
Show resolved
Hide resolved
glasser
requested changes
Sep 29, 2022
packages/server/src/__tests__/plugin/usageReporting/stats.test.ts
Outdated
Show resolved
Hide resolved
glasser
reviewed
Sep 30, 2022
| @@ -61,20 +61,30 @@ export class OurReport implements Required<IReport> { | |||
| trace, | |||
| asTrace, | |||
| referencedFieldsByType, | |||
| // The max size a trace can be before it is sent as stats. Note that the | |||
| // Apollo reporting ingress server will never store any traces over 10mb | |||
| // anyway. They will instead be converted to stats as we would do here. | |||
There was a problem hiding this comment.
I guess my caveat is that traces are always converted to stats too by the ingress — it's not an either/or.
glasser
reviewed
Sep 30, 2022
glasser
reviewed
Sep 30, 2022
Merged
|
I don't think this requires a migration guide entry, as we don't claim this heuristic should be stable (and the end-to-end effect is basically a no-op because of what we do in our servers). |
glasser
pushed a commit
that referenced
this pull request
Sep 30, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-4, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-4` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-4`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @apollo/server-integration-testsuite@4.0.0-rc.15 ### Patch Changes - Updated dependencies \[[`d20842824`](d208428), [`e1455d583`](e1455d5)]: - @apollo/usage-reporting-protobuf@4.0.0-rc.2 - @apollo/server@4.0.0-rc.15 ## @apollo/server@4.0.0-rc.15 ### Patch Changes - [#6897](#6897) [`e1455d583`](e1455d5) Thanks [@bonnici](https://github.com/bonnici)! - Usage reporting: always send traces over 10MB as stats. - Updated dependencies \[[`d20842824`](d208428)]: - @apollo/usage-reporting-protobuf@4.0.0-rc.2 ## @apollo/usage-reporting-protobuf@4.0.0-rc.2 ### Patch Changes - [#6967](#6967) [`d20842824`](d208428) Thanks [@renovate](https://github.com/apps/renovate)! - Update `@apollo/protobufjs` dependency to avoid false positives in vulnerability scans (<#6835>) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send large (>10mb) traces as stats always.