Remove an edge case where GET requests could be treated as batched #7073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a `GET` request whose body was a JSON array with N elements would be interpreted as a batch of the operation specified in the query string repeated N times. Now we just ignore the body for `GET` requests and never treat them as batched. This matches the Apollo Server 3 behavior. (You can try to sneak arrays into Apollo Server 3 GETs by using search parameters like `query[]=`, because AS3 uses the `querystring` npm package instead of the simpler W3C-style `URLSearchParams`. But that won't give you "an array of objects with keys like `query`"; it'll give you "an object with a `query` key whose value is an array", which isn't enough to make it trigger the batch code.) Note that Apollo Client Web's batched HTTP link explicitly refuses to send batched operations over GET.
❌ Deploy Preview for apollo-server-docs failed.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 37d6aad:
|
Merged
glasser
pushed a commit
that referenced
this pull request
Oct 25, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.0.3 ### Patch Changes - [#7073](#7073) [`e7f524eac`](e7f524e) Thanks [@glasser](https://github.com/glasser)! - Never interpret `GET` requests as batched. In previous versions of Apollo Server 4, a `GET` request whose body was a JSON array with N elements would be interpreted as a batch of the operation specified in the query string repeated N times. Now we just ignore the body for `GET` requests (like in Apollo Server 3), and never treat them as batched. - [#7071](#7071) [`0ed389ce8`](0ed389c) Thanks [@glasser](https://github.com/glasser)! - Fix v4 regression: gateway implementations should be able to set HTTP response headers and the status code. - Updated dependencies \[[`e7f524eac`](e7f524e), [`0ed389ce8`](0ed389c)]: - @apollo/server@4.0.3 ## @apollo/server@4.0.3 ### Patch Changes - [#7073](#7073) [`e7f524eac`](e7f524e) Thanks [@glasser](https://github.com/glasser)! - Never interpret `GET` requests as batched. In previous versions of Apollo Server 4, a `GET` request whose body was a JSON array with N elements would be interpreted as a batch of the operation specified in the query string repeated N times. Now we just ignore the body for `GET` requests (like in Apollo Server 3), and never treat them as batched. - [#7071](#7071) [`0ed389ce8`](0ed389c) Thanks [@glasser](https://github.com/glasser)! - Fix v4 regression: gateway implementations should be able to set HTTP response headers and the status code. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a
GETrequest whose body was a JSON array with N elements would be interpreted as a batch of the operation specified in the query string repeated N times. Now we just ignore the body forGETrequests and never treat them as batched. This matches the Apollo Server 3 behavior.(You can try to sneak arrays into Apollo Server 3 GETs by using search parameters like
query[]=, because AS3 uses thequerystringnpm package instead of the simpler W3C-styleURLSearchParams. But that won't give you "an array of objects with keys likequery"; it'll give you "an object with aquerykey whose value is an array", which isn't enough to make it trigger the batch code.)Note that Apollo Client Web's batched HTTP link explicitly refuses to send batched operations over GET.