Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for Rover's introspection command #7285

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

glasser
Copy link
Member

@glasser glasser commented Jan 5, 2023

We once broke this (by dropping support for variables: null). Let's be explicit.

Fixes #7202.

We once broke this (by dropping support for `variables: null`). Let's be
explicit.

Fixes #7202.
@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 3de14af
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/63b6235c41fc0b000ba852cb
😎 Deploy Preview https://deploy-preview-7285--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3de14af:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@glasser
Copy link
Member Author

glasser commented Jan 5, 2023

cc @EverlastingBugstopper

Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!

@glasser glasser merged commit 35fa72b into main Jan 10, 2023
@glasser glasser deleted the glasser/rover-introspection branch January 10, 2023 01:09
trevor-scheer pushed a commit that referenced this pull request Jan 19, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/server-integration-testsuite@4.3.1

### Patch Changes

- [#7285](#7285)
[`35fa72bdd`](35fa72b)
Thanks [@glasser](https://github.com/glasser)! - Adds an integration
test verifying that Rover's introspection query works. This should not
break any integration that passes other tests.

- [#7276](#7276)
[`15c912f4c`](15c912f)
Thanks [@renovate](https://github.com/apps/renovate)! - Update
graphql-http dependency

- Updated dependencies
\[[`ec28b4b33`](ec28b4b),
[`322b5ebbc`](322b5eb),
[`3b0ec8529`](3b0ec85)]:
    -   @apollo/server@4.3.1

## @apollo/server@4.3.1

### Patch Changes

- [#7313](#7313)
[`ec28b4b33`](ec28b4b)
Thanks [@vtipparam](https://github.com/vtipparam)! - Allow case
insensitive lookup on headers. Use HeaderMap instead of plain Map for
headers in expressMiddleware.

- [#7311](#7311)
[`322b5ebbc`](322b5eb)
Thanks [@axe-me](https://github.com/axe-me)! - Export intermediate
ApolloServerOptions\* types

- [#7274](#7274)
[`3b0ec8529`](3b0ec85)
Thanks [@patrick91](https://github.com/patrick91)! - The subgraph spec
has evolved in Federation v2 such that the type of
`_Service.sdl` (formerly nullable) is now non-nullable. Apollo Server
now
    detects both cases correctly in order to determine whether to:
    1.  install / enable the `ApolloServerPluginInlineTrace` plugin
2. throw on startup if `ApolloServerPluginSchemaReporting` should not be
installed
3. warn when `ApolloServerPluginUsageReporting` is installed and
configured with the `__onlyIfSchemaIsNotSubgraph` option

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add integration tests for rover introspect commands
3 participants