Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixes to apolloAzureFunctions.js and sample functions for the GraphQL API and for GraphiQL #753

Merged
merged 4 commits into from
Apr 17, 2018

Conversation

michael-golfi
Copy link
Contributor

@michael-golfi michael-golfi commented Jan 7, 2018

Still a WIP. Addresses #684.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@michael-golfi: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abernix abernix force-pushed the master branch 2 times, most recently from 8126fd2 to 98348a3 Compare April 17, 2018 16:50
@abernix abernix changed the title [WIP] Added fixes to apolloAzureFunctions.js and sample functions for the GraphQL API and for GraphiQL Added fixes to apolloAzureFunctions.js and sample functions for the GraphQL API and for GraphiQL Apr 17, 2018
@abernix abernix merged commit 3dc9719 into apollographql:master Apr 17, 2018
@abernix
Copy link
Member

abernix commented Apr 17, 2018

Thanks for opening this originally, and sorry it took so long to get to!

I've made a tweak which still incorporates your other valuable changes but mainly re-instates the previous syntax and more common pattern of passing the respose directly to context.done. This seems to follow the Azure reference a bit more closely. I've also rebased it on the current master, tested it both with the existing tests and locally using the Azure command line tools.

Hopefully this will solve the problem with Azure functions; we'll get this released soon. Thanks again!

@abernix
Copy link
Member

abernix commented Apr 18, 2018

This should be published in apollo-server-azure-functions@1.3.5. Please report back how it works!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants