Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request data to invalidRequestWasReceived lifecycle event #7886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Masadow
Copy link

@Masadow Masadow commented Jun 10, 2024

Hi,

I want to log all request made to my API and I'm not satisfied by the didEncounterErrors because it discards Bad Request event and such.

By adding more the request object to invalidRequestWasReceived, I will be able to log information regarding the malformed request such as body and headers that will help me trouble shoot issues.

To give a concrete example, I currently have my API that is consumed by several client but one of them is intermittently spawning a lot of Bad Request issue. By having the ability to log all requests along with their headers and body content, I will be capable of identify the client that's causing the Bad Request.

@apollo-cla
Copy link

@Masadow: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Jun 10, 2024

👷 Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5a042f3

Copy link

codesandbox-ci bot commented Jun 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants