Inline @josephg/resolvable dependency
#7900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@trevor-scheer I can confirm that this resolves the issue! |
|
@trevor-scheer Thank you for this fix. |
Merged
trevor-scheer
pushed a commit
that referenced
this pull request
Jul 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.10.5 ### Patch Changes - [#7821](#7821) [`b2e15e7`](b2e15e7) Thanks [@renovate](https://github.com/apps/renovate)! - Non-major dependency updates - [#7900](#7900) [`86d7111`](86d7111) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Inline a small dependency that was causing build issues for ESM projects - Updated dependencies \[[`b2e15e7`](b2e15e7), [`86d7111`](86d7111)]: - @apollo/server@4.10.5 ## @apollo/server@4.10.5 ### Patch Changes - [#7821](#7821) [`b2e15e7`](b2e15e7) Thanks [@renovate](https://github.com/apps/renovate)! - Non-major dependency updates - [#7900](#7900) [`86d7111`](86d7111) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Inline a small dependency that was causing build issues for ESM projects Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Aug 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7895 reports that AS4 fails to build for ESM due to the resolvable dependency.
I'm actually unsure why this is happening though, since the shipped JS appears to be ESM compatible:
https://unpkg.com/@josephg/resolvable@1.0.1/index.js
@macrozone would you mind testing the builds from this PR (see Codesandbox CI comment) and letting me know if this resolves the issue in your project?