Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export out GraphQLOptions in apollo-server-express #871

Merged
merged 6 commits into from
Mar 16, 2018
Merged

Re-export out GraphQLOptions in apollo-server-express #871

merged 6 commits into from
Mar 16, 2018

Conversation

epicallan
Copy link
Contributor

@epicallan epicallan commented Mar 12, 2018 •
edited by abernix
Loading

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Closes #863

@ghost ghost added the good first review label Mar 12, 2018
@abernix
Merge branch 'master' into master
8f18f26
@abernix
Export GraphQLOptions type directly from apollo-server-express.
f07ad2f 
Directly export `GraphQLOptions` from the `apollo-server-express` (and
synonymously, `graphql-server-express`) main module, rather than exporting
it only from `./expressApollo`.

While the type would have still been available to someone using "connect"
middleware, this could yield less shake-win for connect developers who might be
tree-shaking, as they'd unnecessarily introduce the "express" middleware entry
points.
@abernix abernix changed the title [ #863] re-export out GraphQLOptions in apollo-server-express Re-export out GraphQLOptions in apollo-server-express Mar 16, 2018
@ghost ghost added the good first review label Mar 16, 2018
@ghost ghost added the good first review label Mar 16, 2018
@abernix abernix merged commit c9a3728 into apollographql:master Mar 16, 2018
@abernix
Copy link
Member

abernix commented Mar 16, 2018

Thank you! I made a slight adjustment with f07ad2f, but will release this in the next version.

@epicallan
Copy link
Contributor Author

Thank you to.

@epicallan epicallan mentioned this pull request Mar 16, 2018
Open
This was referenced Mar 26, 2018
Closed
Open
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@abernix abernix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epicallan @abernix