Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.29.0 #2032

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Release 2.29.0 #2032

merged 5 commits into from
Jul 10, 2020

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Jul 7, 2020

As with release PRs in the past, this is a PR tracking a release-x.y.z branch for an upcoming release of Apollo Tooling. 🙌 The version in the title of this PR should correspond to the appropriate branch.

Check the appropriate milestone (to the right) for more details on what we hope to get into this release!

The intention of these release branches is to gather changes which are intended to land in a specific version (again, indicated by the subject of this PR). Release branches allow additional clarity into what is being staged, provide a forum for comments from the community pertaining to the release's stability, and to facilitate the creation of pre-releases (e.g. alpha, beta, rc) without affecting the master branch.

PRs for new features might be opened against or re-targeted to this branch by the project maintainers. The master branch may be periodically merged into this branch up until the point in time that this branch is being prepared for release. Depending on the size of the release, this may be once it reaches RC (release candidate) stage with an -rc.x release suffix. Some less substantial releases may be short-lived and may never have pre-release versions.

When this version is officially released onto the latest npm tag, this PR will be merged into master.

Fixes #1947

This PR makes the minimal number of changes necessary for the apollo-tooling's
repository's tests to pass for the planned graphql@15.x release.

Notable changes to implementations are as follows:

an adjustment to account for the new onError callback introduced by
graphql/graphql-js#2074, which deprecated the previously used
ValidationContext.prototype.getErrors method.

utilize the GraphQLEnumValueConfig type instead of GraphQLEnumValue
(which lead to the removal of the name field, which isn't actually needed when
building the values for the GraphQLEnumType constructor.

Ref: graphql/graphql-js#2303

Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
@trevor-scheer trevor-scheer added this to the Release 2.29.0 milestone Jul 7, 2020
 - apollo-codegen-core@0.37.4-alpha.0
 - apollo-codegen-flow@0.35.4-alpha.0
 - apollo-codegen-scala@0.36.4-alpha.0
 - apollo-codegen-swift@0.37.4-alpha.0
 - apollo-codegen-typescript@0.37.4-alpha.0
 - apollo-graphql@0.5.0-alpha.0
 - apollo-language-server@1.23.0-alpha.0
 - apollo@2.29.0-alpha.0
 - vscode-apollo@1.16.4-alpha.0
 - apollo-codegen-core@0.37.4
 - apollo-codegen-flow@0.35.4
 - apollo-codegen-scala@0.36.4
 - apollo-codegen-swift@0.37.4
 - apollo-codegen-typescript@0.37.4
 - apollo-language-server@1.23.0
 - apollo@2.29.0
 - vscode-apollo@1.16.4
@trevor-scheer trevor-scheer merged commit 3e441ee into master Jul 10, 2020
@trevor-scheer trevor-scheer deleted the release-2.29.0 branch July 10, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apollo client:codegen --target typescript gives TypeError: context.getErrors is not a function
2 participants