Add fallback for git branch calculation #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evans
force-pushed
the
evans/use-prBranch-fallback
branch
from
6c3947d
to
5b5fe71
Compare
trevor-scheer
approved these changes
Jan 4, 2019
In some ci's, the git branch will not be present in the environment with the default that env-ci uses, so we need to provide a fallback. The fallback is either the PR's branch if present or the .git branch. This branch is used inside of the Engine frontend to display more information about the schema changes. See https://github.com/pvdlg/env-ci#caveats for a longer list of cases when the branch will not be present in the ci environment
evans
force-pushed
the
evans/use-prBranch-fallback
branch
from
5b5fe71
to
d05447d
Compare
JakeDawkins
pushed a commit
that referenced
this pull request
Jan 16, 2019
In some ci's, the git branch will not be present in the environment with the default that env-ci uses, so we need to provide a fallback. The fallback is either the PR's branch if present or the .git branch. This branch is used inside of the Engine frontend to display more information about the schema changes. See https://github.com/pvdlg/env-ci#caveats for a longer list of cases when the branch will not be present in the ci environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some ci's, the git branch will not be present in the environment with
the default that env-ci uses, so we need to provide a fallback. The
fallback is either the PR's branch if present or the .git branch. This
branch is used inside of the Engine frontend to display more information
about the schema changes.
See https://github.com/pvdlg/env-ci#caveats for a longer list of cases
when the branch will not be present in the ci environment