Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node@18 and update CI processes #73

Merged
merged 10 commits into from
Apr 26, 2022

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Apr 26, 2022

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2022

🦋 Changeset detected

Latest commit: 0e734ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/utils.createhash Minor
@apollo/utils.dropunuseddefinitions Minor
@apollo/utils.isnodelike Minor
@apollo/utils.operationregistrysignature Minor
@apollo/utils.printwithreducedwhitespace Minor
@apollo/utils.sortast Minor
@apollo/utils.stripsensitiveliterals Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@@ -8130,15 +8130,15 @@
"sha.js": "^2.4.11"
},
"engines": {
"node": ">=12.13.0 <18.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevor-scheer Can we drop explicit limitations on future versions of Node?
AFAIK, it's the only package that does that and it doesn't use a lot of Node API (only crypto and process).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fine with me 👍

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Couple things:

  • Would you remove the node upper limit from the top-level package file as well?
  • This needs a changeset (patch bump for all packages) so we can release the update after landing this.

.circleci/config.yml Outdated Show resolved Hide resolved
@IvanGoncharov
Copy link
Member Author

@trevor-scheer I resolved all comments

@trevor-scheer
Copy link
Member

@IvanGoncharov thanks for letting me turn this into a "Fix CI" branch 😄 looks like things are working as expected now!

@trevor-scheer trevor-scheer changed the title Add support for node@18 Add support for node@18 and update CI processes Apr 26, 2022
@trevor-scheer trevor-scheer merged commit 25721d9 into apollographql:main Apr 26, 2022
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants