-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for node@18 and update CI processes #73
Conversation
🦋 Changeset detectedLatest commit: 0e734ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@@ -8130,15 +8130,15 @@ | |||
"sha.js": "^2.4.11" | |||
}, | |||
"engines": { | |||
"node": ">=12.13.0 <18.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trevor-scheer Can we drop explicit limitations on future versions of Node?
AFAIK, it's the only package that does that and it doesn't use a lot of Node API (only crypto
and process
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's fine with me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Couple things:
- Would you remove the node upper limit from the top-level package file as well?
- This needs a changeset (patch bump for all packages) so we can release the update after landing this.
53d1e2b
to
57e9a17
Compare
@trevor-scheer I resolved all comments |
@IvanGoncharov thanks for letting me turn this into a "Fix CI" branch 😄 looks like things are working as expected now! |
Blocks apollographql/apollo-server#6350