WIP: investigate permitting FormData as a body in requests
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
trevor-scheer
commented
Nov 29, 2022
| body != null && | ||
| typeof body !== 'string' && | ||
| !(body instanceof Buffer) && | ||
| body.constructor.name !== 'FormData' |
There was a problem hiding this comment.
We anticipate different FormData types, not sure of a better way to identify
trevor-scheer
force-pushed
the
trevor/form-data
branch
from
4d0a1b4
to
9f40bb1
Compare
trevor-scheer
force-pushed
the
trevor/form-data
branch
from
9f40bb1
to
5920f67
Compare
|
Closing in favor of #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precedes #90 if favorable.
I'm not excited by the complexity in typings this introduces. This work spun out as an investigation in response to this comment: #90 (comment)
Unfortunately the generic
TFormDatahas to be piped into everything that looks at request objects.