Remove didReceiveResponse hook

.changeset/khaki-cars-remember.md

@@ -0,0 +1,20 @@
+---
+'@apollo/datasource-rest': major
+---
+
+Remove `didReceiveResponse` hook
+
+The naming of this hook is deceiving; if this hook is overridden it becomes
+responsible for returning the parsed body and handling errors if they occur. It
+was originally introduced in
+https://github.com/apollographql/apollo-server/issues/1324, where the author
+implemented it due to lack of access to the complete response (headers) in the
+fetch methods (get, post, ...). This approach isn't a type safe way to
+accomplish this and places the burden of body parsing and error handling on the
+user.
+
+Removing this hook is a prerequisite to a subsequent change that will introduce
+the ability to fetch a complete response (headers included) aside from the
+provided fetch methods which only return a body. This change will reinstate the
+functionality that the author of this hook had originally intended in a more
+direct manner.

README.md

@@ -154,11 +154,6 @@ override cacheOptionsFor() {
 }
 ```
 
-##### `didReceiveResponse`
-By default, this method checks if the response was returned successfully and parses the response into the result object. If the response had an error, it detects which type of HTTP error and throws the error result.
-
-If you override this behavior, be sure to implement the proper error handling.
-
 ##### `didEncounterError`
 By default, this method just throws the `error` it was given. If you override this method, you can choose to either perform some additional logic and still throw, or to swallow the error by not throwing the error result.
 

src/RESTDataSource.ts

@@ -176,17 +176,6 @@ export abstract class RESTDataSource {
  request: FetcherRequestInit,
  ): CacheOptions | undefined;
 
- protected async didReceiveResponse<TResult = any>(
- response: FetcherResponse,
- _request: RequestOptions,
- ): Promise<TResult> {
- if (response.ok) {
- return this.parseBody(response) as any as Promise<TResult>;
- } else {
- throw await this.errorFromResponse(response);
- }
- }
-
  protected didEncounterError(error: Error, _request: RequestOptions) {
  throw error;
  }
@@ -353,9 +342,15 @@ export abstract class RESTDataSource {
  cacheKey,
  cacheOptions,
  });
- return await this.didReceiveResponse(response, outgoingRequest);
+
+ if (response.ok) {
+ return (await this.parseBody(response)) as TResult;
+ } else {
+ throw await this.errorFromResponse(response);
+ }
  } catch (error) {
  this.didEncounterError(error as Error, outgoingRequest);
+ throw error;
  }
  });
  };