Two body-related commits #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode-fetch This commit makes two changes whose implementation ended up related: - Writing to the HTTP-header-sensitive cache should not block the response! We now do it in the background. If the caller wants to block (eg for tests), it should call `fetch` and `await` the `cacheWritePromise`. Errors writing to the cache are logged by default; override `catchCacheWritePromiseErrors` to change this. - If you're using `node-fetch` (or another library that uses its `Headers` implementation) and the response has multiple separate headers with the same name, the `node-fetch` Headers object that we return now internally has those separate headers too, so the (`node-fetch`-specific) `response.headers.raw()` will let you see the duplicate-header structure. (Especially helpful for `set-cookie` headers.) If you override `parseBody`, you should preserve its behavior of always fully reading the response, or else for large responses the background "write to cache" task can block and leak memory. Fixes #75.
Previously, the deduplication logic shared the response body across both responses; if you mutate that response, it will affect other deduplicated responses. Now we clone the body. If you override `parseBody` to return new data types, you should override `cloneParsedBody` to properly clone them. There's probably an optimization that can be done to skip the cloning if there was no duplicate operation (and it's in `deduplicate-during-request-lifetime` mode). Fixes #18.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
trevor-scheer
approved these changes
Dec 14, 2022
| }; | ||
| } | ||
|
|
||
| protected cloneParsedBody<TResult>(parsedBody: TResult) { |
There was a problem hiding this comment.
We'll need a README update for this
There was a problem hiding this comment.
parseBody itself isn't documented. Will deal with that in another pass over all protected methods today.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review individual commits.