Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve
body
on request object passed towillSendRequest
; fixstring
andBuffer
body handling #89Preserve
body
on request object passed towillSendRequest
; fixstring
andBuffer
body handling #89Changes from 18 commits
9f339b8
3a014ab
2f8c68f
b1f9182
7bbbdfa
3a223f1
896c0cb
bf9ca45
d77f7ff
177e437
e2a241c
66979be
da3bd0d
7ee320d
75c40f9
5666808
e7f914f
4d1d4d2
e685e90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth a comment that the point here is basically, this is like DataSourceRequest but with
headers
andparams
normalized for convenience in your callbacks.BTW unrelated but it seems like
method
shouldn't be optional in GetRequest/RequestWithBody?