This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
clarify preview release #854
Draft
shorgi
wants to merge
1
commit into
main
Choose a base branch
from
eh/DOC-124/prod-launch-stages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for apollo-monodocs failed.
|
Meschreiber
reviewed
May 20, 2024
A preview might still contain bugs or undergo iteration. You're encouraged to try previews in test environments to familiarize yourself with upcoming functionality before it reaches [general availability](#general-availability). | ||
Previews aren't officially supported with any SLA, and breaking API changes are possible between incremental versions of a preview. | ||
|
||
We encourage you to provide your feedback about functionality and issues you encounter when trying previews in your development and test environments. We might release multiple previews before the functionality reaches [general availability](#general-availability). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This verbiage suggests previews should only be used in dev/test environments. I'm not sure if we want to limit them to this?
Suggested change
We encourage you to provide your feedback about functionality and issues you encounter when trying previews in your development and test environments. We might release multiple previews before the functionality reaches [general availability](#general-availability). | |
We encourage you to provide your feedback about functionality and issues you encounter when trying preview features. We might release multiple previews before the functionality reaches [general availability](#general-availability). |
Meschreiber
reviewed
May 20, 2024
@@ -53,4 +55,4 @@ Products, features, and open-source releases that reach end-of-life are no longe | |||
|
|||
End-of-life releases published to a package registry aren't removed from that registry. This means you can still install end-of-life versions past the end-of-life date (though Apollo strongly recommends against this). | |||
|
|||
Do not run end-of-life open-source releases in production. Upgrade to the latest generally available release as soon as possible to ensure you continue receiving security patches, bug fixes, new features, and compatibility with GraphOS features. | |||
**Do not run end-of-life open-source releases in production**. Upgrade to the latest generally available release as soon as possible to ensure you continue receiving security patches, bug fixes, new features, and compatibility with GraphOS features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Stellar's feedback, we should limit bolding for UI elements and italics for new features. Not sure if this needs emphasis.
Suggested change
**Do not run end-of-life open-source releases in production**. Upgrade to the latest generally available release as soon as possible to ensure you continue receiving security patches, bug fixes, new features, and compatibility with GraphOS features. | |
Do not run end-of-life open-source releases in production. Upgrade to the latest generally available release as soon as possible to ensure you continue receiving security patches, bug fixes, new features, and compatibility with GraphOS features. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.