This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Allow for GOOGLE_AUTH_KEY to be unset when running docs locally
#909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for apollo-monodocs failed.
|
Meschreiber
approved these changes
Jul 15, 2024
jerelmiller
force-pushed
the
jerel/loosen-analytics-key
branch
from
1748503
to
c34ea18
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely convinced this is the right solution, but at least this should provide some discussion. When I try and run docs locally, I'm unable to when it tries to run the algolia script because it tries running
.replaceon a string that isundefined. Theundefinedstring is due to theGOOGLE_AUTH_KEYenvironment variable not set, so the app is unable to start.This PR adds optional chaining to allow for that value to be unset so we can at least startup the client locally without it. Please let me know if you think of a better way to handle this! I'm not sure if this would cause silent errors or not.