feat: add a check for deprecation errors

apollographql · Nov 9, 2017 · ba24262 · ba24262
1 parent d3de0db
commit ba24262
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -5,6 +5,7 @@ import {
   buildClientSchema,
   buildSchema,
   specifiedRules as allGraphQLValidators,
+  findDeprecatedUsages
 } from 'graphql';
 
 import {
@@ -372,6 +373,16 @@ function handleTemplateTag(node, context, schema, env, validators) {
     });
     return;
   }
+
+  const deprecationErrors = schema ? findDeprecatedUsages(schema, ast) : [];
+  if (deprecationErrors && deprecationErrors.length > 0) {
+    context.report({
+      node,
+      message: deprecationErrors[0].message,
+      loc: locFrom(node, deprecationErrors[0]),
+    });
+    return;
+  }
 }
 
 function locFrom(node, error) {

diff --git a/test/makeRule.js b/test/makeRule.js
@@ -526,6 +526,28 @@ const parserOptions = {
           column: 19
         }]
       },
+      {
+        options,
+        parser,
+        code: `
+          @relay({
+            fragments: {
+              greetings: () => Relay.QL\`
+                fragment on Greetings {
+                  hi,
+                }
+              \`,
+            }
+          })
+          class HelloApp extends React.Component {}
+        `,
+        errors: [{
+          message: "The field Greetings.hi is deprecated. Please use the more formal greeting 'hello'",
+          type: 'TaggedTemplateExpression',
+          line: 6,
+          column: 19
+        }]
+      },
 
       // Example from issue report:
       // https://github.com/apollostack/eslint-plugin-graphql/issues/12#issuecomment-215445880

diff --git a/test/schema.graphql b/test/schema.graphql
@@ -45,6 +45,7 @@ type Film {
 type Greetings {
   id: ID
   hello: String
+  hi: String @deprecated(reason: "Please use the more formal greeting 'hello'")
 }
 
 type Story {