-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust v1.78.0 router-bridge startup panic #595
Comments
Deno is known to have problems with Rust version above 1.76. So, any crates that use router-bridge are currently stuck with rustc 1.76. |
Thanks for the reply @duckki, do you have an issue or source link for the problem? This is concerning because cargo is starting to move past this version |
Deno itself seems to be developing with 1.82.0, at least: https://github.com/denoland/deno/blob/main/rust-toolchain.toml So I'm interested in the issues deno has with 1.76+. I can't find anything on their issue tracker. |
This is also reproducible with
|
The router team identified issues from binaries compiled with rustc version 1.77 or later. I don't know the details. But, the source of issue is presumed to be from deno. Though, it may not cause router-bridge testing itself to fail. @robmarto It may be necessary to "pin" dependent packages to their older versions to build your projects. Several Apollo projects had to pin |
Thanks @duckki. I have I've done this in the meantime to keep moving but its far from ideal, and is only a temporary solution which becomes less and less viable as time goes on IMO. I do wonder if anyone is actually looking into this problem though? Has it even been raised with the Deno team? |
Yes, it's a temporary workaround. The router project is going to remove deno pretty soon. Then, we should be freed from this restriction. |
apollographql/router#5084
Putting this here in case the issue is within this repo
Upgrading Rust Toolchain to 1.78.0 causes panic on startup in router-bridge for --release builds
Steps to reproduce the behavior:
Output
2024-05-03T21:42:30.961533Z ERROR panicked at /Users/[redacted]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/router-bridge-0.5.18+v2.7.2/src/worker.rs:101:38: called 'Result::unwrap()' on an 'Err' value: TypeError: Error parsing args at position 1: serde_v8 error: invalid type; expected: object, got: string at send (worker.js:54:25) at run (worker.js:171:19)
Desktop (please complete the following information):
OS: macOS / Linux
Version macOS 13.6.1 / public.ecr.aws/docker/library/rust:1.78.0
The text was updated successfully, but these errors were encountered: