Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust v1.78.0 router-bridge startup panic #5084

Open
str1aN opened this issue May 3, 2024 · 9 comments
Open

Rust v1.78.0 router-bridge startup panic #5084

str1aN opened this issue May 3, 2024 · 9 comments

Comments

@str1aN
Copy link

str1aN commented May 3, 2024

Upgrading Rust Toolchain to 1.78.0 causes panic on startup in router-bridge for --release builds

Steps to reproduce the behavior:

  1. Upgrade Rust toolchain to 1.78.0
  2. Build and Start router with cargo run --release -- (env vars omitted)
  3. See error on startup

Output

2024-05-03T21:42:30.961533Z ERROR panicked at /Users/[redacted]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/router-bridge-0.5.18+v2.7.2/src/worker.rs:101:38: called 'Result::unwrap()' on an 'Err' value: TypeError: Error parsing args at position 1: serde_v8 error: invalid type; expected: object, got: string at send (worker.js:54:25) at run (worker.js:171:19)

Desktop (please complete the following information):

  • OS: macOS / Linux
  • Version macOS 13.6.1 / public.ecr.aws/docker/library/rust:1.78.0
@abernix
Copy link
Member

abernix commented May 6, 2024

We'll need to look into this — and we will — but we haven't yet made the jump to Rust v1.78.0 (currently, we are on Rust 1.76.0). We'll take some time to make the jump, so we would recommend using 1.76.0 for now.

@abernix abernix changed the title Upgrading Rust Toolchain to 1.78.0 causes panic on startup in router-bridge Rust v1.78.0 router-bridge panic May 6, 2024
@abernix abernix changed the title Rust v1.78.0 router-bridge panic Rust v1.78.0 router-bridge startup panic May 6, 2024
kamilkisiela added a commit to graphql-hive/console that referenced this issue Jul 19, 2024
@Dr-Emann
Copy link

Rust 1.76 is now over 6 months old, is there any timeline on when we can move forward on rust versions?

@robmarto
Copy link

I agree, some of my dependencies sqlx have released security vulnerability fixes in latest versions that will only compile on rust 1.80+. Unfortunately I can't take them since this won't compile.

@yanns
Copy link
Contributor

yanns commented Sep 2, 2024

@abernix is it something the community can help?
Is it quite easy, like updating the rust version, and fixing all warnings?
Or is it something more complex, as updating dependencies first, then the project?

@y-nk
Copy link

y-nk commented Sep 17, 2024

i have the same issue over rust 1.76 - it builds but doesn't run.

on the side i'm not sure of why we need worker.js on that project. could it be separated/optional deps?

@Dr-Emann
Copy link

Rust 1.76 has now been unsupported for 8 months.

@y-nk
Copy link

y-nk commented Nov 22, 2024

@Dr-Emann i was just mentioning that it may be something bigger than rust version since i also had it for another (previous) version :|

@robmarto
Copy link

@abernix now getting further blocked in my pipelines because cargo-platform v0.1.9` cannot be built because it requires rustc 1.78 or newer.
It's a pretty common cargo dependency (cargo-machete, cargo-tarpaulin) use this, so now I'm expected to pin these to older version now to :<

Honestly, I think bumping your rust version needs to be a priority now. As mentioned previously 1.76 has been unsupported for 8 months now.

@duckki
Copy link
Contributor

duckki commented Dec 13, 2024

The latest dev branch dropped deno and is now on the latest rustc! It's planned to be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants