release: composition@v2.0.0 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Not really sure what is happening here but It might be worth a check (in the error message as well i guess).
Otherwise lgtm! 🙌
|
Thanks for double-checking that @o0Ignition0o! That code should be safe to keep around, since it's checking for a minimum version where we support pinning the composition version. It can probably be removed at some point since it would only be helpful for people trying out the 2.x preview releases (which are mostly internal users). |
o0Ignition0o
approved these changes
Apr 11, 2022
dingxiangfei2009
pushed a commit
to dingxiangfei2009/federation-rs
that referenced
this pull request
Jun 23, 2022
…l#102) This cargo cults a lot of stuff from the `federation` repository, which has had this configuration in place for a long time now. Granted this does add a lot of lines, most of it is to account for our use of the query-planner written in Node.js within the Router. The additional jockery is to account for various learnings and differences between the operating systems, including how they have to have Node.js installed. Aside from also running on macOS and Windows, it has various other benefits that relate to our use cases: - Hoists the responsibility of toolchain stuff to CircleCI Orbs' Rust pkg - Pins the version of Node.js (and npm that we depend on for our query planner integration, rather than having them be whatever is within the CircleCI node variant of the Rust image. It's certainly possible that we'll want this in the code itself to facilitate developing on those environments, but I think it's too soon to invest heavily in having Node.js as a dependency for long-term. Closes apollographql#91 Closes apollographql#100 Co-authored-by: Jesse Rosenberger <git@jro.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.