router-bridge: Update to @apollo/query-planner@2.0.0-alpha.6
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is expected since the [Ref]erenced PR introduced it! Ref: apollographql/federation#1427
abernix
commented
Feb 14, 2022
| @@ -10,7 +10,8 @@ expression: "serde_json::to_string_pretty(&plan::<serde_json::Value>(Operational | |||
| "kind": "Fetch", | |||
| "serviceName": "accounts", | |||
| "variableUsages": [], | |||
| "operation": "{me{name{first last}}}" | |||
| "operation": "{me{name{first last}}}", | |||
| "operationKind": "query" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
It's worth noting that the cargo insta review also wanted me to add a:
assertion_line: 174...directly under the source: router-bridge/src/plan.rs at the top of this .snap file (becoming line 3, and pushing the current line 3 down), but I did not include that:
This was referenced Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably to bring in apollographql/federation#1511
Ref: apollographql/federation@ee84b3fd9df161c3a94