Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query planner configuration option generate_query_fragments #460

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Mar 21, 2024

Ref: apollographql/federation#2958

Adopting this in router should take into consideration that both reuse_query_fragments and generate_query_fragments should not both be set to true. Since reuse_ currently defaults to true, it should be disabled when generate_ is enabled.

@trevor-scheer trevor-scheer requested a review from a team as a code owner March 21, 2024 20:24
@trevor-scheer trevor-scheer force-pushed the trevor/generate-query-fragments branch 2 times, most recently from e19da5d to 444d2d8 Compare March 21, 2024 22:13
@trevor-scheer trevor-scheer force-pushed the create-pull-request/router-bridge branch from d29e0ab to e222c0a Compare March 21, 2024 22:14
@trevor-scheer trevor-scheer merged commit 640dc3a into create-pull-request/router-bridge Mar 21, 2024
8 checks passed
@trevor-scheer trevor-scheer deleted the trevor/generate-query-fragments branch March 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants