get heap statistics from deno #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tninesling
reviewed
Aug 7, 2024
tninesling
approved these changes
Aug 7, 2024
o0Ignition0o
approved these changes
Aug 8, 2024
abernix
reviewed
Aug 8, 2024
| #[derive(Serialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| struct MemoryUsage { | ||
| //rss: usize, |
There was a problem hiding this comment.
keep or go? (i commented on the release PR just now but it's the same question)
| let mut s = v8::HeapStatistics::default(); | ||
| scope.get_heap_statistics(&mut s); | ||
| MemoryUsage { | ||
| //rss: rss(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a planner event to request V8 heap statistics.
This data is gathered from the JS side because the related methods from the rust side require a
&mutaccess to the runtime, which is impossible since it already runs in an infinite loop.Since we elected to not run the prelude parts of deno which register functions like
Deno.memory_usage, we intern the op_runtime_memory_usage function and import it directly as a host function, as we've done already withop_crypto_get_random_values. To avoid hosting too much code, therssfield is not filled (it needs platform specific functions), since that info can generally be obtained by other means.