Skip to content

Commit

Permalink
inefficient query plans when using @context (#3140)
Browse files Browse the repository at this point in the history
Fixes edge case where contextual arguments can lead to inefficient query
plans. Also fixes naming of query plan arguments which can be a problem
when using contextual variables in multiple subraphs.

---------

Co-authored-by: Sachin D. Shinde <sachin@apollographql.com>
  • Loading branch information
clenfest and sachindshinde authored Oct 15, 2024
1 parent bdefb7a commit 345661c
Show file tree
Hide file tree
Showing 4 changed files with 616 additions and 180 deletions.
6 changes: 6 additions & 0 deletions .changeset/fuzzy-readers-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@apollo/query-planner": patch
"@apollo/query-graphs": patch
---

Fixes edge case where contextual arguments can yield inefficient query plans. Also fixes naming of query plan arguments which can be a problem when using contextual variables in multiple subgraphs
3 changes: 3 additions & 0 deletions .gitleaksignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
98882688d195e195234d8af24fd64fdd6d105a2b:query-planner-js/src/tests/buildPlan.test.ts:9178
ff5e2fac1ed4731c3392546a361291b3905b494b:query-planner-js/src/tests/buildPlan.test.ts:10334
ff5e2fac1ed4731c3392546a361291b3905b494b:query-planner-js/src/tests/buildPlan.test.ts:10339
Loading

0 comments on commit 345661c

Please sign in to comment.