The previous change fixes an outstanding TODO in an interfaces-implem…

…enting-interfaces test, so we update the test
apollographql · Aug 21, 2024 · 496e5a3 · 496e5a3
1 parent 8a6bfec
commit 496e5a3
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/gateway-js/src/__tests__/executeQueryPlan.test.ts b/gateway-js/src/__tests__/executeQueryPlan.test.ts
@@ -2300,22 +2300,14 @@ describe('executeQueryPlan', () => {
 
       queryPlan = buildPlan(operation, queryPlanner);
 
-      // TODO: we're actually type-exploding in this case because currently, as soon as we need to type-explode, we do
-      // so into all the runtime types, while here it could make sense to only type-explode into the direct sub-types=
-      // (the sub-interfaces). We should fix this (but it's only sub-optimal, not incorrect).
       expect(queryPlan).toMatchInlineSnapshot(`
         QueryPlan {
           Fetch(service: "S1") {
             {
               allValues {
                 __typename
-                ... on T1 {
-                  a
-                }
-                ... on T2 {
-                  a
-                }
-                ... on T4 {
+                ... on SubInterface1 {
+                  __typename
                   a
                 }
               }