Skip to content

Commit

Permalink
feat: SECOPS-2525 - add semgrep job (#2906)
Browse files Browse the repository at this point in the history
## Motivation / Implements

This PR adds or updates the necessary configuration to enable
[Semgrep](https://semgrep.dev/docs/semgrep-code/overview/) to run on PRs
on this repo. The Apollo Security team uses Semgrep to test our source
for potential security vulnerabilities.

Once this is accepted and merged, the Security team plans to make a
passing Semgrep check a requirement for PRs to merge into this repo.
This will prevent net-new severe issues from being introduced. The job
proposed by this PR runs in a diff-aware mode, so it will only run
Semgrep on the files that have changed in a given PR.

In the event that a severe issue _is_ detected on a PR, the CI job will
add a comment to the PR associated with the detection to provide
instructions on how to properly resolve the detection. The comment added
to PRs will also include instructions on how to get further support if
needed.

If maintainers reviewing this PR have questions, please reach out in the
`#security` channel in Slack or contact Matt Peake directly at
`matt[.]peake@apollographql[.]com`.

## Existing Findings
  
Semgrep does not currently detect any severe issues in this repo.

## Changed

- Updated `.circleci/config.yml` to include appropriate configuration to
enable Semgrep as a CI check. These changes were programmatically
generated, so YAML formatting may have been modified to conform to the
YAML spec.
- Updated SecOps orb to latest version
  • Loading branch information
svc-secops authored Jan 10, 2024
1 parent 69495b4 commit 5f7ff5e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2.1

orbs:
node: circleci/node@5.1.0
secops: apollo/circleci-secops-orb@2.0.1
secops: apollo/circleci-secops-orb@2.0.6

jobs:
# Unfortunately cimg/node doesn't tag its images with major only, you have to specify a minor version.
Expand Down Expand Up @@ -68,3 +68,8 @@ workflows:
- secops-oidc
git-base-revision: <<#pipeline.git.base_revision>><<pipeline.git.base_revision>><</pipeline.git.base_revision >>
git-revision: << pipeline.git.revision >>
- secops/semgrep:
context:
- secops-oidc
- github-orb
git-base-revision: <<#pipeline.git.base_revision>><<pipeline.git.base_revision>><</pipeline.git.base_revision >>

0 comments on commit 5f7ff5e

Please sign in to comment.