Disallow composing @authenticated via @composeDirective

apollographql · Jul 12, 2023 · 70b695d · 70b695d
1 parent 0662fdb
commit 70b695d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/composition-js/src/__tests__/compose.composeDirective.test.ts b/composition-js/src/__tests__/compose.composeDirective.test.ts
@@ -261,7 +261,7 @@ describe('composing custom core directives', () => {
   });
 
   it.each([
-    '@tag', '@inaccessible',
+    '@tag', '@inaccessible', '@authenticated',
   ])('federation directives that result in a hint', (directive) => {
     const subgraphA = generateSubgraph({
       name: 'subgraphA',
@@ -282,13 +282,13 @@ describe('composing custom core directives', () => {
   });
 
   it.each([
-    '@tag', '@inaccessible',
+    '@tag', '@inaccessible', '@authenticated',
   ])('federation directives (with rename) that result in a hint', (directive) => {
     const subgraphA = {
       name: 'subgraphA',
       typeDefs: gql`
       extend schema
-        @link(url: "https://specs.apollo.dev/federation/v2.1", import: [{ name: "@key" }, { name: "@composeDirective" } , { name: "${directive}", as: "@apolloDirective" }])
+        @link(url: "https://specs.apollo.dev/federation/v2.5", import: [{ name: "@key" }, { name: "@composeDirective" } , { name: "${directive}", as: "@apolloDirective" }])
         @link(url: "https://specs.apollo.dev/link/v1.0")
         @composeDirective(name: "@apolloDirective")
 

diff --git a/composition-js/src/composeDirectiveManager.ts b/composition-js/src/composeDirectiveManager.ts
@@ -171,6 +171,7 @@ export class ComposeDirectiveManager {
     const directivesComposedByDefault = [
       sg.metadata().tagDirective(),
       sg.metadata().inaccessibleDirective(),
+      sg.metadata().authenticatedDirective(),
     ].map(d => d.name);
     if (directivesComposedByDefault.includes(directive.name)) {
       this.pushHint(new CompositionHint(