Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-upgraded schemas get upgraded to latest federation version. #2932

Closed
clenfest opened this issue Feb 6, 2024 · 0 comments · Fixed by #2933
Closed

auto-upgraded schemas get upgraded to latest federation version. #2932

clenfest opened this issue Feb 6, 2024 · 0 comments · Fixed by #2933
Assignees
@clenfest

Comments

@clenfest
Copy link
Contributor

clenfest commented Feb 6, 2024

Issue Description

We should restrict schemas that don't manually @link federation to a fixed version of federation so they aren't upgraded to the latest (and thus require the new version of the join spec, etc. I'm thinking that we shouldn't promote any of these auto-upgraded subgraphs to 2.6 (i.e. they wouldn't have to go past version 0.3 of the join spec.

Link to Reproduction

n/a

Reproduction Steps

No response
@clenfest clenfest self-assigned this Feb 6, 2024
@clenfest clenfest mentioned this issue Feb 7, 2024
Merged
clenfest added a commit that referenced this issue Feb 8, 2024
@clenfest
Limit version of auto-upgraded subgraphs (#2933)
09cd3e5 
Do not auto-upgrade federation subgraphs past fed 2.4. This is so that
we don't inadvertently require a router that supports the latest join
spec when it's not needed.

Fixes #2932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clenfest clenfest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit version of auto-upgraded subgraphs apollographql/federation
1 participant
@clenfest