Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-planner): Include operationKind and operationName in FetchNodes (backport) #1609

Merged
merged 6 commits into from
Mar 17, 2022

Conversation

trevor-scheer
Copy link
Member

Backport of:
#1427
#1550 + #1568

This maintains parity in the query plan format with v2 by generating operation names for subgraph fetches. This also brings in the addition of operationKind out of convenience / maintaining parity since the changes are so closely related.

cc @chrskrchr who I know was interested in this addition for v0.x and @lennyburdette as the implementor of the name generation

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pcmanus
Copy link
Contributor

pcmanus commented Mar 16, 2022

Regarding operation names, this needs to include the changes from 82d810f. But looks good to me otherwise.

@trevor-scheer
Copy link
Member Author

Thanks @pcmanus, good catch (I had missed those tests altogether during my cherry-pick). Needs an actual approval then I'll land!

Copy link
Contributor

@pcmanus pcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. But I'd make sure we don't forget a changelog entry that mentions that queries sent to subgraph can now be named since it's a small but visible-ish change (I could see a user have tests that needs update due to this).

@trevor-scheer trevor-scheer merged commit 982266e into version-0.x Mar 17, 2022
@trevor-scheer trevor-scheer deleted the trevor/backport-1550 branch March 17, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants