federation: fix warning for mismatched unnamed @external
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some TypeScript weirdness means we were getting the GraphQLNamedType overload of typeFromAST, which meant we were calling `.name` on it, which is undefined for non-null and list types.
glasser
force-pushed
the
apollo-server-import/pr-4392
branch
from
7f28421 to
ac4d447
Compare
trevor-scheer
approved these changes
Sep 21, 2020
|
Originally at: apollographql/apollo-server#4392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TypeScript weirdness means we were getting the GraphQLNamedType overload of
typeFromAST, which meant we were calling
.nameon it, which is undefined fornon-null and list types.