Try implementing subgraph-js using the federation internals #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pcmanus
force-pushed
the
subgraph-with-internals
branch
from
e62004f
to
fffa695
Compare
clenfest
reviewed
Apr 11, 2022
| @@ -60,6 +61,58 @@ function addTypeNameToPossibleReturn<T>( | |||
| return maybeObject as null | (T & { __typename: string }); | |||
| } | |||
|
|
|||
| export function entitiesResolver({ | |||
There was a problem hiding this comment.
Is there any functional change in this file that I'm not seeing or is it just a non-functional refactor?
There was a problem hiding this comment.
There is not change to the resolver code, but it extract it as a method because it's called in buildSubgraphSchema directly now.
| @@ -593,7 +593,7 @@ describe('@core/@link handling', () => { | |||
|
|
|||
| type Query { | |||
| _entities(representations: [_Any!]!): [_Entity]! | |||
| _service: _Service | |||
| _service: _Service! | |||
clenfest
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.