Triggers user friendly message on supergraph extracting errors more o… #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
added 2 commits
April 29, 2022 11:12
…ften When encountering errors while extract subgraphs from fed1 supergraph, which can happen due to stricter fed2 validations, we were providing an error message suggesting that user try fed2 composition, but that message was only triggered for error thrown when validating the extracted subgraph, but some error may be triggered earlier in the extraction process. This commit ensure that the try-catch we use to trigger that more helpful error message is widenned to enclose all of the extraction code.
pcmanus
force-pushed
the
widen-catch-supergraph
branch
from
19c9d53
to
735c822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ften
When encountering errors while extract subgraphs from fed1 supergraph,
which can happen due to stricter fed2 validations, we were providing
an error message suggesting that user try fed2 composition, but that
message was only triggered for error thrown when validating the
extracted subgraph, but some error may be triggered earlier in the
extraction process.
This commit ensure that the try-catch we use to trigger that more
helpful error message is widenned to enclose all of the extraction
code.