Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix applying auto-imported federation directive on other directive de… #1797

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fix applying auto-imported federation directive on other directive de… #1797

merged 2 commits into from
Apr 29, 2022

Commits on Apr 29, 2022

  1. Fix applying auto-imported federation directive on other directive de… 

    …finition

For subgraphs, applying an auto-imported federation directive (say
`@tag`) to another directive definition argument was triggering a
non-sensical error. That is because we want trying to handle such
directive application _before_ we had properly auto-imported its
definition.

This patch ensure we delay the building of such directive application
to after the auto-importing mechanism has been performed.

Fixes apollographql#1794
    Sylvain Lebresne committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    112acbf View commit details
    Browse the repository at this point in the history

  2. Changelogs

    Sylvain Lebresne committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    cbe7a1b View commit details
    Browse the repository at this point in the history