Fix potential rogue expansion of fragments when deoptimizing #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
approved these changes
Aug 26, 2022
added 2 commits
August 26, 2022 09:06
The code from apollographql#1911 ensures that named fragments from the user query are reused in subgraph query "when appropriate", but there were some code path where a fragment that was reused (correctly) could end up be "re-expanded" (due to an existing method not handling spreads properly). The resulting subgraph query ended up with the fragment definition existing but never being used, which is invalid in graphQL. This patch ensures that a reused fragment is not mistakenly re-expanded by the code (and thus avoids a query with unused fragments). Fixes apollographql#2092
pcmanus
force-pushed
the
f2096-fragments-issue
branch
from
0b44f14 to
91a0eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code from #1911 ensures that named fragments from the user query are
reused in subgraph query "when appropriate", but there were some code
path where a fragment that was reused (correctly) could end up be
"re-expanded" (due to an existing method not handling spreads properly).
The resulting subgraph query ended up with the fragment definition
existing but never being used, which is invalid in graphQL.
This patch ensures that a reused fragment is not mistakenly re-expanded
by the code (and thus avoids a query with unused fragments).
Fixes #2092