Improves error message for misspelled override #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
approved these changes
Oct 11, 2022
added 2 commits
October 12, 2022 10:32
When mispelling the `from` of an `@override`, one can easily run into an error about the field needing to be "shareable", which doesn't help locate the actual problem easily. This patch detect this situation and provide an additional hint in the error message to hopefully make the root cause easier to locate.
pcmanus
force-pushed
the
override-hint
branch
from
f6bb97e
to
23fc408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mispelling the
fromof an@override, one can easily run into an error about the field needing to be "shareable", which doesn't help locate the actual problem easily. This patch detect this situation and provide an additional hint in the error message to hopefully make the root cause easier to locate.