Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call FeatureUrl.parse directly if it could throw #2912

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Don't call FeatureUrl.parse directly if it could throw #2912

merged 2 commits into from
Jan 19, 2024

Conversation

clenfest
Copy link
Contributor

No description provided.

@clenfest clenfest requested a review from a team as a code owner January 19, 2024 18:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 35fad14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jan 19, 2024 •
edited
Loading

✅ Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit 838417c
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/65aabc8399aab60008d9813b

@clenfest clenfest changed the base branch from main to next January 19, 2024 18:17
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 19, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@clenfest clenfest merged commit 56a7816 into next Jan 19, 2024
15 checks passed
@clenfest clenfest deleted the clenfest/url_parse_fixes2 branch January 19, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-scheer trevor-scheer trevor-scheer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clenfest @trevor-scheer