Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test / documentation around SchemaUpgrader behavior #2919

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Jan 31, 2024

The release of 2.7 and more specifically join/v0.4 has been troublesome for multiple reasons. One assumption I made that hasn't helped the situation is that at least one subgraph would have to explicitly opt-in to fed 2.7 by updating the version in their federation @link directive.

Unfortunately, the schema upgrader upgrades subgraphs to the latest federation spec version by default when the subgraph is identified as a non-fed2 subgraph, i.e. no @link federation spec is provided.

The test added here demonstrates this behavior, but mostly serves as a required touchpoint for upgrading the federation spec version with some documentation describing the behavior and why it might cause challenges.

@trevor-scheer trevor-scheer requested a review from a team as a code owner January 31, 2024 22:03
Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 32ee23b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit 32ee23b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/65bac40f4600f00008f98909

Copy link

codesandbox-ci bot commented Jan 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trevor-scheer trevor-scheer merged commit 82976d5 into main Jan 31, 2024
19 checks passed
@trevor-scheer trevor-scheer deleted the trevor/add-upgrader-test branch January 31, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants