-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new generateQueryFragments
option to query planner config
#2958
Merged
dariuszkuc
merged 18 commits into
apollographql:main
from
trevor-scheer:trevor/auto-frag-no-ast
Mar 18, 2024
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ffac1ff
initial
trevor-scheer 15ede23
restore indentation
trevor-scheer e47c424
changeset
trevor-scheer 2ba043e
whitespace
trevor-scheer 1d1c79c
whitespace again
trevor-scheer 27beaad
i'm actually confused now, this should pass though
trevor-scheer 159d92c
don't reuse fragment spreads (parentType may vary)
trevor-scheer 0f35281
use inlinesnapshot instead
trevor-scheer fbcff7a
new test case for equivalent but not identical selections
trevor-scheer 14a36e3
fix + update test
trevor-scheer cb74201
simplify id generation
trevor-scheer 7b35388
improve name generation
trevor-scheer 7516b00
simplify API of minimize function a bit
trevor-scheer ddd2100
comments
trevor-scheer 0bc859f
spelling
trevor-scheer a189852
_
trevor-scheer c00429d
update mock hash code
trevor-scheer e8560f8
seen selections should capture the original selection set, not the mi…
trevor-scheer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
"apollo-federation-integration-testsuite": minor | ||
"@apollo/query-planner": minor | ||
"@apollo/federation-internals": minor | ||
--- | ||
|
||
Add new `generateQueryFragments` option to query planner config | ||
|
||
If enabled, the query planner will extract inline fragments into fragment definitions before sending queries to subgraphs. This can significantly reduce the size of the query sent to subgraphs, but may increase the time it takes to plan the query. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FragmentSelection
is an abstract class implemented byInlineFragmentSelection
andFragmentSpreadSelection
, so I don't think you'll need to change the definition here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2960