Ensure query variables used in the directives applied at the operation level are retained in subgraph queries #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure query variables used in the directives applied at the operation level are retained in subgraph queries
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 77d2cf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dariuszkuc
approved these changes
Apr 19, 2024
o0Ignition0o
pushed a commit
that referenced
this pull request
Apr 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 - @apollo/query-graphs@2.7.4 ## @apollo/gateway@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0), [`c89d8287e88d12cfd34c1baf1f42db672731b8a7`](c89d828)]: - @apollo/query-planner@2.7.4 - @apollo/federation-internals@2.7.4 - @apollo/composition@2.7.4 ## @apollo/federation-internals@2.7.4 ### Patch Changes - Fixed a regression created by PR (#2967), where directives would not be properly attached to their parent. (#2982) ([#2984](#2984)) ## @apollo/query-graphs@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 ## @apollo/query-planner@2.7.4 ### Patch Changes - Fixed a regression created by PR (#2967), where directives would not be properly attached to their parent. (#2982) ([#2984](#2984)) - Ensure query variables used in the directives applied at the operation level are retained in subgraph queries (#2986) ([#2986](#2986)) - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 - @apollo/query-graphs@2.7.4 ## @apollo/subgraph@2.7.4 ### Patch Changes - Updated dependencies \[[`d80b7f0ca1456567a0866a32d2b2abf940598f77`](d80b7f0)]: - @apollo/federation-internals@2.7.4 ## apollo-federation-integration-testsuite@2.7.4 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
duckki
added a commit
that referenced
this pull request
Oct 12, 2024
…le_usages` field Related PR: #2986
sachindshinde
pushed a commit
that referenced
this pull request
Oct 14, 2024
…leUsages` field (#3166) Fixed missing referenced variables in the `variableUsages` field of fetch operations Query variables used in fetch operation should be listed in the `variableUsages` field. However, there was a bug where variables referenced by query-level directives could be missing in the field. The previous PR (#2986) fixed a similar issue in fetch queries, but it didn't fully fix the issue by failing to update the `variableUsages` field. This PR completes the remaining issue. <!-- [FED-387] --> [FED-387]: https://apollographql.atlassian.net/browse/FED-387?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another regression created by PR #2967.
Related: #2961