generateQueryFragments error with nested selection set #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 894de02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dariuszkuc
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
clenfest
pushed a commit
that referenced
this pull request
Jun 28, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 - @apollo/query-graphs@2.8.2 ## @apollo/gateway@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 - @apollo/composition@2.8.2 - @apollo/query-planner@2.8.2 ## @apollo/federation-internals@2.8.2 ### Patch Changes - generateQueryFragments() could generate fragments with naming collisions when nested ([#3043](#3043)) ## @apollo/query-graphs@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 ## @apollo/query-planner@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 - @apollo/query-graphs@2.8.2 ## @apollo/subgraph@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 ## apollo-federation-integration-testsuite@2.8.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Meschreiber
pushed a commit
that referenced
this pull request
Jul 9, 2024
Fixes #3042 generateQueryFragments does't handle repeated (... on B { ... on B ... on B } } }) fragments well. Given the query planner can actually generate these query structures, this causes this option to be potentially dangerous, generating invalid subgraph queries. --------- Co-authored-by: Marc-Andre Giroux <mgiroux@netflix.com>
Meschreiber
pushed a commit
that referenced
this pull request
Jul 9, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 - @apollo/query-graphs@2.8.2 ## @apollo/gateway@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 - @apollo/composition@2.8.2 - @apollo/query-planner@2.8.2 ## @apollo/federation-internals@2.8.2 ### Patch Changes - generateQueryFragments() could generate fragments with naming collisions when nested ([#3043](#3043)) ## @apollo/query-graphs@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 ## @apollo/query-planner@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 - @apollo/query-graphs@2.8.2 ## @apollo/subgraph@2.8.2 ### Patch Changes - Updated dependencies \[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]: - @apollo/federation-internals@2.8.2 ## apollo-federation-integration-testsuite@2.8.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3042
generateQueryFragments does't handle repeated (... on B { ... on B ... on B } } }) fragments well. Given the query planner can actually generate these query structures, this causes this option to be potentially dangerous, generating invalid subgraph queries.