Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Prettier on internals-js #3050

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

dylan-apollo
Copy link
Member

Part of #3046, split out for easier review.

@dylan-apollo dylan-apollo requested a review from a team as a code owner June 25, 2024 21:44
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: f73fa0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylan-apollo dylan-apollo changed the base branch from main to next June 25, 2024 21:44
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit f73fa0d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/667b3a2fedd9e10008f8c9dc

@dylan-apollo dylan-apollo mentioned this pull request Jun 25, 2024
3 tasks
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dylan-apollo dylan-apollo merged commit 5a72dd8 into next Jun 26, 2024
19 checks passed
@dylan-apollo dylan-apollo deleted the dylan/prettier-on-internals branch June 26, 2024 16:25
sachindshinde pushed a commit that referenced this pull request Sep 9, 2024
<!-- [CNN-217] -->

TODO:

- [x] Merge #3048 and rebase this 
- [x] Merge #3049 and rebase this
- [x] Merge #3050 and rebase this

Summary:

- Removes support for `@source*` directives
- Adds support for `@connect` and `@source`

[CNN-217]:
https://apollographql.atlassian.net/browse/CNN-217?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Lenny Burdette <lenny@apollographql.com>
Co-authored-by: Ben Newman <ben@apollographql.com>
Co-authored-by: Taylor Jones <45475656+tayrrible@users.noreply.github.com>
Co-authored-by: Taylor Jones <taylor@apollographql.com>
Co-authored-by: Nicholas Cioli <nicholas.cioli@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants