Make SchemaUpgrader faster #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 484c957 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👷 Deploy Preview for apollo-federation-docs processing.
|
✅ Deploy Preview for apollo-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
pushed a commit
that referenced
this pull request
Jul 25, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.8.4 ### Patch Changes - When doing interface type intersection detection, allow @interfaceObject to stand in for any type ([#3087](#3087)) - Updated dependencies \[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16), [`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]: - @apollo/federation-internals@2.8.4 - @apollo/query-graphs@2.8.4 ## @apollo/gateway@2.8.4 ### Patch Changes - Updated dependencies \[[`4d9e0f6390c5114132d205ab73b6aa1b9ffa8cd8`](4d9e0f6), [`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16), [`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]: - @apollo/composition@2.8.4 - @apollo/federation-internals@2.8.4 - @apollo/query-planner@2.8.4 ## @apollo/federation-internals@2.8.4 ### Patch Changes - When auto-upgrading schemas from fed1, never add @Shareable on subscription fields. ([#3094](#3094)) - Save time in SchemaUpgrader by pre-computing which subgraphs contain each type ([#3057](#3057)) ## @apollo/query-graphs@2.8.4 ### Patch Changes - Updated dependencies \[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16), [`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]: - @apollo/federation-internals@2.8.4 ## @apollo/query-planner@2.8.4 ### Patch Changes - Updated dependencies \[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16), [`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]: - @apollo/federation-internals@2.8.4 - @apollo/query-graphs@2.8.4 ## @apollo/subgraph@2.8.4 ### Patch Changes - Add descriptions for federation directives ([#3095](#3095)) - Updated dependencies \[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16), [`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]: - @apollo/federation-internals@2.8.4 ## apollo-federation-integration-testsuite@2.8.4 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make SchemaUpgrader faster by precomputing each type into a map that can be passed around once rather. Ideally we would be able to entirely get rid of
otherSubgraphsas a parameter to SchemaUpgrader before this PR is ready.Note that although this works with tests, I think there may be an issue with interfaces that isn't covered by tests, so do not merge unless someone has a chance to look at this with a critical eye. (I think the issue is that the map is built by iterating over
objectTypesbut later code iterates overtypes()which may include interfaces.