Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests for bugs fixed by #3134 and #3136 #3146

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

sachindshinde
Copy link
Contributor

The PRs #3134 and #3136 were merged without tests illustrating the bugs they were fixing. This PR adds tests for two of the bugs fixed by them; these tests fail on 2.9.0, but succeed after the aforementioned PRs.

@sachindshinde sachindshinde requested a review from a team as a code owner September 17, 2024 17:58
Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: f49b35f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit f49b35f
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/66e9c34ad3e16c0009bfdb7f

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sachindshinde sachindshinde merged commit 72ebc48 into main Sep 17, 2024
19 checks passed
@sachindshinde sachindshinde deleted the sachin/add-tests-for-2.9.0-bugs branch September 17, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants