Fixes issue where there can be naming collisions in contextual parameter names #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sachindshinde
approved these changes
Sep 25, 2024
sachindshinde
pushed a commit
that referenced
this pull request
Sep 27, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.9.2 ### Patch Changes - Updated dependencies \[[`2192f355f50db33fe0807d16153f357696b9f190`](2192f35), [`e1e2605b30efc488b57f62ba43436606a38a3607`](e1e2605), [`5ac01b534318105e904c1e6598070f753add3bb1`](5ac01b5)]: - @apollo/federation-internals@2.9.2 - @apollo/query-graphs@2.9.2 ## @apollo/gateway@2.9.2 ### Patch Changes - Updated dependencies \[[`2192f355f50db33fe0807d16153f357696b9f190`](2192f35), [`e1e2605b30efc488b57f62ba43436606a38a3607`](e1e2605), [`5ac01b534318105e904c1e6598070f753add3bb1`](5ac01b5)]: - @apollo/query-planner@2.9.2 - @apollo/federation-internals@2.9.2 - @apollo/composition@2.9.2 ## @apollo/federation-internals@2.9.2 ### Patch Changes - Fixes handling of a `__typename` selection during query planning process. ([#3156](#3156)) When expanding fragments we were keeping references to the same `Field`s regardless where those fragments appeared in our original selection set. This was generally fine as in most cases we would have same inline fragment selection sets across whole operation but was causing problems when we were applying another optimization by collapsing those expanded inline fragments creating a new selection set. As a result, if any single field selection (within that fragment) would perform optimization around the usage of `__typename`, ALL occurrences of that field selection would get that optimization as well. - Add validations for demand control directive applications ([#3148](#3148)) ## @apollo/query-graphs@2.9.2 ### Patch Changes - Fixes issue where contextual parameters can have naming collisions if used in multiple subgraphs ([#3155](#3155)) - Updated dependencies \[[`2192f355f50db33fe0807d16153f357696b9f190`](2192f35), [`5ac01b534318105e904c1e6598070f753add3bb1`](5ac01b5)]: - @apollo/federation-internals@2.9.2 ## @apollo/query-planner@2.9.2 ### Patch Changes - Fixes handling of a `__typename` selection during query planning process. ([#3156](#3156)) When expanding fragments we were keeping references to the same `Field`s regardless where those fragments appeared in our original selection set. This was generally fine as in most cases we would have same inline fragment selection sets across whole operation but was causing problems when we were applying another optimization by collapsing those expanded inline fragments creating a new selection set. As a result, if any single field selection (within that fragment) would perform optimization around the usage of `__typename`, ALL occurrences of that field selection would get that optimization as well. - Fixes issue where contextual parameters can have naming collisions if used in multiple subgraphs ([#3155](#3155)) - Updated dependencies \[[`2192f355f50db33fe0807d16153f357696b9f190`](2192f35), [`e1e2605b30efc488b57f62ba43436606a38a3607`](e1e2605), [`5ac01b534318105e904c1e6598070f753add3bb1`](5ac01b5)]: - @apollo/federation-internals@2.9.2 - @apollo/query-graphs@2.9.2 ## @apollo/subgraph@2.9.2 ### Patch Changes - Updated dependencies \[[`2192f355f50db33fe0807d16153f357696b9f190`](2192f35), [`5ac01b534318105e904c1e6598070f753add3bb1`](5ac01b5)]: - @apollo/federation-internals@2.9.2 ## apollo-federation-integration-testsuite@2.9.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subgraph number set for a contextual paramter was colliding if used in multiple subgraphs